Review chapter 08 prettification #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xronophobe
commented
Oct 20, 2023
chapter_08_prettification.asciidoc
Outdated
| @@ -971,7 +1012,7 @@ INSTALLED_APPS = [ | |||
| "django.contrib.sessions", | |||
| "django.contrib.messages", | |||
| "django.contrib.staticfiles", | |||
| "lists", | |||
| "lists.apps.ListsConfig", | |||
There was a problem hiding this comment.
Btw my INSTALLED_APPS have single quote entries, why are these double quotes? Maybe some auto-formatter?
There was a problem hiding this comment.
i ran black on everything at some point. and i think django does too now, so everything in settings.py has double quotes these days...
(also i change to just using "lists" rather than lists.apps.ListConfig because the latter just seems needlesscly complicated.
Xronophobe
force-pushed
the
review--chapter-08-prettification
branch
from
666779d to
ed2c7b2
Compare
Xronophobe
commented
Oct 20, 2023
| @@ -822,6 +859,7 @@ All that took me a few goes, but I'm reasonably happy with it now | |||
| [[homepage-looking-better]] | |||
| .The lists page, looking good enough for now... | |||
| image::images/prettified-final.png["Screenshot of lists page in light mode with decent styling."] | |||
| // CSANAD: This image seemed to be broken, so I uploaded a new one. | |||
There was a problem hiding this comment.
Please check the resolution, my image is significantly smaller in size.
hjwp
reviewed
Oct 30, 2023
hjwp
reviewed
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice, faster-paced chapter, easy to follow and seeing the visual upgrade on the Lists page is a very rewarding feeling.
I was wondering whether Bootstrap is still a future-proof choice, considering the changes at Twitter, but it seems like it is: https://github.com/orgs/twbs/discussions/38986
ps.: I just noticed we are going with Python 3.12 now. I was using 3.11 for reviewing the chapter, but I think it shouldn't be a problem.