Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of deprecated Selenium APIs on Ch12 #198

Closed
wants to merge 3 commits into from

Conversation

gclves
Copy link

@gclves gclves commented Oct 25, 2023

Selenium's find_element_by_* methods have been deprecated, in favor of find_element.

Selenium's `find_element_by_*` methods have been deprecated, in favor of `find_element`.
Copy link
Author

@gclves gclves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯_(ツ)_/¯

chapter_organising_test_files.asciidoc Outdated Show resolved Hide resolved
chapter_organising_test_files.asciidoc Outdated Show resolved Hide resolved
@hjwp
Copy link
Owner

hjwp commented Oct 30, 2023

hey! thanks so much for helping out!

by coincidence, i've actually been working on some updates to chapter 12 over in another branch. #190

my fault for not merging it sooner!!

i'm working through all the chapters slowly upgrading them to python 3.12 and django 4, as part of the third edition, so i will get round to them all eventually.

if you'd like to help, i'd love your thoughts on my new versions of the deployment chapters? drop me an email to [email protected] and i'll send you a pdf...

@hjwp hjwp closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants