Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Route Search Remark #142

Closed
wants to merge 16 commits into from
Closed

Conversation

LOOHP
Copy link
Contributor

@LOOHP LOOHP commented Jan 22, 2024

Changes the "route remark" underneath each route in the search screen from the first stop to the difference between itself and the main line.

Open to further discussion.

@LOOHP
Copy link
Contributor Author

LOOHP commented Jan 28, 2024

Welcome to review for input.

@chunlaw
Copy link
Member

chunlaw commented Feb 12, 2024

image

The idea is very good, while there is small bug. Would you be able to use useMemo to boost the performance as well?

@LOOHP
Copy link
Contributor Author

LOOHP commented Feb 16, 2024

Sure thing

@thomas930
Copy link
Contributor

Any Progress update?

@pantinker
Copy link
Collaborator

pantinker commented Mar 24, 2024

補返 LOOHP 自己寫的解釋:

不如我都解釋清楚啲一次
個PR係用呢個rule compare主線同特別班
First matching rule applies
如果:

  1. 起點不同:寫起點
  2. 終點不同:寫終點
  3. 有多咗站:寫經...
  4. 少咗站:寫不經...

另外如果係嶼巴 會係前面再加埋起點 assuming rule 1 did not already applied

For 經同埋不經
如果所以多咗/少咗嘅站都係連續
會寫 經/不經First至Last
唔係就會寫多咗/少咗嘅第一個同最後一個站
經/不經First及Last


今朝有人因為 UI 唔夠清淅而睇錯嶼巴 3M 嘅起訖點描述

我就話如果格式改為:
起點 > 終點
翻譯做任何語言都會好容易用「>」理解到行車方向。

假設某條路線同一方向
有 相同起(A)訖(D)點嘅 正常班次(第 1 行)同 特別班次(第 2﹑3 行)共 3 種行法,參考上邊以符號代替文字,似乎可以咁寫(B﹑C﹑X﹑Y 係中途站):
A > ✅ B ❌ X > ✅ C ❌ Y > D
A > ✅ X ❌ B > ✅ Y ❌ C > D
A > ❌ B ❌ C > D

怕太長可以咁寫:
✅ B ✅ C
✅ X ✅ Y
❌ B ❌ C

怕剔叉有人唔明就咁寫:
A > B > C > D
A > X > Y > D
A > B > C > D
我唔知刪除線會唔會仲有人睇唔明啦

無記錯嘅話 James 個 PR 會就 3 種唔同行法寫出以下描述:
經 B 及 C
經 X 及 Y
不經 B 及 C

@LOOHP
Copy link
Contributor Author

LOOHP commented May 15, 2024

Superceeded by #182.

@LOOHP LOOHP closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants