[ALS-5056] Create sumtype for QueryRequest #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Luke-Sikina
commented
Oct 11, 2023
Luke-Sikina
commented
- Interface, implementations for general use, GIC
Luke-Sikina
force-pushed
the
query-request-sumtype
branch
5 times, most recently
from
3570179 to
8a7a843
Compare
JamesPeck
reviewed
Oct 16, 2023
| * QueryRequests for vanilla GIC PIC-SURE. Includes details about the source | ||
| * of the request, the requester, and any unifying identifiers for sharing | ||
| */ | ||
| public class GICQueryRequest implements QueryRequest { |
There was a problem hiding this comment.
Can we name this something more generic? The implementation of a common area may one day be applied outside of GIC.
There was a problem hiding this comment.
FederatedQueryRequest
Luke-Sikina
commented
Oct 16, 2023
pic-sure-api-war/src/main/java/edu/harvard/dbmi/avillach/security/JWTFilter.java
Outdated
Show resolved
Hide resolved
Luke-Sikina
commented
Oct 16, 2023
pic-sure-api-war/src/main/java/edu/harvard/dbmi/avillach/service/PicsureSearchService.java
Outdated
Show resolved
Hide resolved
Luke-Sikina
commented
Oct 16, 2023
...esources/pic-sure-ga4gh-dos/src/main/java/edu/harvard/hms/dbmi/avillach/GA4GHResourceRS.java
Outdated
Show resolved
Hide resolved
Luke-Sikina
force-pushed
the
site-of-origin
branch
from
8221ff9 to
06bacfa
Compare
Luke-Sikina
force-pushed
the
query-request-sumtype
branch
from
8a7a843 to
5d66b90
Compare
Luke-Sikina
force-pushed
the
site-of-origin
branch
from
06bacfa to
3b9fcea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.