-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ALS-3978] Update version handling in multiple pom.xml files #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes hardcoded versions of dependencies from individual pom.xml files and introduces them into the root pom.xml's properties section. This centralizes the control of dependency versions to prevent inconsistencies and makes future updates more straightforward. This change covers several libraries including Guava, JUnit Jupiter, Mockito, and others.
Gcolon021
added
ignore-for-release
dependencies
Pull requests that update a dependency file
labels
Dec 8, 2023
Upgraded dependencies including Jackson, Guava, JUnit, Hibernate, HttpClient, and Commons-IO. Also, improved the management of versions via property variables and cleaned up inconsistent formatting. Removed an unnecessary comment related to Mockito version compatibility.
The changes encompass the removal of explicit version references in the project's pom.xml files. By relying on property variables, this maintenance update enhances dependency management flexibility. Specific version comments also have been removed to eliminate clutter and improve overall file readability.
The changes primarily involve updating the pom.xml file to use property variables instead of hardcoding the version numbers. This is a better approach as it improves the flexibility in managing dependencies. This change also results in cleaner and more readable code by removing unnecessary explicit version references.
The Spring version has been downgraded in the pom.xml file from 6.1.1 to 5.3.31. This is due to java version requirement of 17+ for 6.x
Luke-Sikina
approved these changes
Dec 19, 2023
Luke-Sikina
added
enhancement
New feature or request
and removed
dependencies
Pull requests that update a dependency file
labels
Dec 19, 2023
srpiatt
approved these changes
Dec 19, 2023
Gcolon021
added a commit
that referenced
this pull request
Dec 21, 2023
* [ALS-5422] Add persistence.xml to visualization resource (#161) (#162) The visualization resource is failing to start due to an error injecting persistence unit into CDI managed bean. It is unable to find a persistence unit named ''. * Sync new Release/0008 with Master (#168) * [ALS-5422] Add persistence.xml to visualization resource (#161) The visualization resource is failing to start due to an error injecting persistence unit into CDI managed bean. It is unable to find a persistence unit named ''. * [ALS-0000] Fix aggregate resource - Very confused as to how this was working before * [ALS-5422] Add persistence.xml to visualization resource (#161) (#162) (#163) The visualization resource is failing to start due to an error injecting persistence unit into CDI managed bean. It is unable to find a persistence unit named ''. --------- Co-authored-by: Luke Sikina <[email protected]> * [ALS-5061] Remove HSAPIResource (#166) [ALS-5061] Remove HSAPIResource (#166) * [ALS-3978] Update version handling in multiple pom.xml files (#167) * [ALS-3978] Update version handling in multiple pom.xml files This commit removes hardcoded versions of dependencies from individual pom.xml files and introduces them into the root pom.xml's properties section. This centralizes the control of dependency versions to prevent inconsistencies and makes future updates more straightforward. This change covers several libraries including Guava, JUnit Jupiter, Mockito, and others. * Update library versions and clean up pom.xml Upgraded dependencies including Jackson, Guava, JUnit, Hibernate, HttpClient, and Commons-IO. Also, improved the management of versions via property variables and cleaned up inconsistent formatting. Removed an unnecessary comment related to Mockito version compatibility. * Remove specific version references in pom.xml files The changes encompass the removal of explicit version references in the project's pom.xml files. By relying on property variables, this maintenance update enhances dependency management flexibility. Specific version comments also have been removed to eliminate clutter and improve overall file readability. * Update pom.xml to use property variables for versions The changes primarily involve updating the pom.xml file to use property variables instead of hardcoding the version numbers. This is a better approach as it improves the flexibility in managing dependencies. This change also results in cleaner and more readable code by removing unnecessary explicit version references. * Downgrade Spring version in pom.xml The Spring version has been downgraded in the pom.xml file from 6.1.1 to 5.3.31. This is due to java version requirement of 17+ for 6.x --------- Co-authored-by: Luke Sikina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ALS-5509] [ALS-3978] Refactored maven pom.xml files so the parent pom now declares the dependency versions. Additionally, I have resolved a number of security vulnerabilities discovered by dependabot by updating dependency versions.