ALS-7778: Fix bottleneck in wildfly #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsumption Reduced the default maximum connections per route from 20 to 5 for better resource management. Also, added logic to consume and close the HttpResponse entity properly to avoid potential resource leaks.
Initialize 'resourcesResponse' before the try block and ensure its entity is consumed in the finally block. This change ensures that the HttpResponse resource is properly released, preventing potential resource leaks.
Added finally blocks to consume HttpResponse entities in multiple methods to ensure proper resource cleanup and avoid potential memory leaks. This also includes adding null checks for the HttpResponse objects and handling IOExceptions if entity consumption fails. Conversion from private Logger to final Logger is also included for consistency.
Replaced redundant response entity consumption logic with a dedicated method to improve code clarity and maintainability. Simplified test assertions by directly casting response entities to strings, ensuring consistency across test cases.
Updated PoolingHttpClientConnectionManager across several classes to increase the default maximum connections per route from 5 to 20. This change aims to enhance resource handling efficiency and improve overall application performance during high traffic scenarios.
ramari16
commented
Nov 4, 2024
| @@ -75,8 +75,8 @@ private static void parseCommandLine(String[] args) throws ParseException, FileN | |||
| printHelpAndExit(); | |||
| } | |||
| url = cmd.getOptionValue("p"); | |||
| users = IOUtils.toString(new FileInputStream(cmd.getOptionValue("u")), "UTF-8"); | |||
| resources = IOUtils.toString(new FileInputStream(cmd.getOptionValue("r")), "UTF-8"); | |||
| users = EntityUtils.toString(new FileInputStream(cmd.getOptionValue("u")), "UTF-8"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implemented connection pooling and cleaned up a lot of issues that this change exposed