Implement Aggregate dispatcher.
#26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it ready for a review? |
| public function __construct(array $dispatchers, array $parameters = []) | ||
| { | ||
| $this->setDispatchers($dispatchers); | ||
| parent::__construct($parameters); |
There was a problem hiding this comment.
Reverse these two lines. If the constructor override your data, you will have a surprise :-).
There was a problem hiding this comment.
Of course yes 😄 ! I've updated the code...
|
Yes it is ready for review 😄. |
It must be used to resolve routes on multiple dispatchers at once.
shulard
force-pushed
the
feature/issue-14
branch
from
391d787 to
3cdc73d
Compare
|
Hello, I've just rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've worked on the #14 issue. I've introduced the
Aggregateclass and added a test suite based on the current lib state (using theClassMethodimplementation).Maybe the tests can be updated when the specific Dispatchers implementation issues are merged.