-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ObjectMethod
dispatcher.
#27
base: master
Are you sure you want to change the base?
Conversation
Is it ready for a review? |
I think it is ! Based on the current |
2fd43c5
to
0bf8337
Compare
Same here, I've rebased on master 😄. |
Allow to dispatch route on an already constructed object.
0bf8337
to
ef69bb9
Compare
ef69bb9
to
a3b3fe8
Compare
Hello @Hywan, I've rebased my code on master, for me the implementation is done. I've one question about custom object logic during tests. I know that I can mock Router and Kit relatively easily but the Is there a cleaner way to handle that ? |
Hello !
I've worked on the #16 issue about
ObjectMethod
dispatcher. I tried to use only theobject
logic inside theBasic
dispatcher combined with the refactoredClassMethod
.For the moment it's a first step but there is a lot of duplicated code between the different dispatchers (parameters retrieving, ClassMethod vs ObjectMethod...). I think that we'll discuss about a refactoring when the dispatcher split will be done.