Catch errors when changing remotes (#140)

holepunchto · Oct 4, 2023 · 817019d · 817019d
1 parent 364ea20
commit 817019d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/connect.js b/lib/connect.js
@@ -364,7 +364,9 @@ async function connectThroughNode (c, address, socket) {
     if (c.rawStream === null) return // Already hole punched
 
     if (c.rawStream.connected) {
-      c.rawStream.changeRemote(socket, c.connect.payload.udx.id, port, host)
+      const remoteChanging = c.rawStream.changeRemote(socket, c.connect.payload.udx.id, port, host)
+
+      if (remoteChanging) remoteChanging.catch(noop)
     } else {
       c.rawStream.connect(socket, c.connect.payload.udx.id, port, host)
 

diff --git a/lib/server.js b/lib/server.js
@@ -234,7 +234,9 @@ module.exports = class Server extends EventEmitter {
         hs.rawStream.removeListener('error', autoDestroy)
 
         if (hs.rawStream.connected) {
-          hs.rawStream.changeRemote(socket, remotePayload.udx.id, port, host)
+          const remoteChanging = hs.rawStream.changeRemote(socket, remotePayload.udx.id, port, host)
+
+          if (remoteChanging) remoteChanging.catch(noop)
         } else {
           hs.rawStream.connect(socket, remotePayload.udx.id, port, host)