Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use catch(safetyCatch) instead of noop #154

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Use catch(safetyCatch) instead of noop #154

merged 3 commits into from
Jan 2, 2024

Conversation

HDegroote
Copy link
Contributor

@HDegroote HDegroote commented Dec 18, 2023

Might need to be merged together with holepunchto/hyperswarm#170, because hyperswarm at some point removes a noop listener created in hyperdht's lib/connect (although I couldn't trace which one exactly)

lib/connection-pool.js Outdated Show resolved Hide resolved
@mafintosh mafintosh merged commit 8f675eb into main Jan 2, 2024
4 checks passed
@mafintosh mafintosh deleted the use-safetyCatch branch January 2, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants