Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Server state machine + clean up edge cases #202

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HDegroote
Copy link
Contributor

The existing logic didn't take into account the edge case that a connection can exist for a while in the server before being passed to the DHT itself (notably, during the handshake, and during the holepunching while the connection is still relayed).

I'm pretty sure this partially explains the Hyperswarm lifecycle issue documented here: https://github.com/holepunchto/hyperswarm/blob/d8eab5249ac76076a4257e2cdcad9d086f2c7d61/index.js#L291-L293

@HDegroote
Copy link
Contributor Author

Marked as draft because I'm unsure on the cleanest solution for some cases, indicated with TODO's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant