-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/combined writes - one packet can ship multiple writes #173
Closed
jthomas43
wants to merge
37
commits into
holepunchto:main
from
jthomas43:feature/combined-writes-2024
Closed
Feature/combined writes - one packet can ship multiple writes #173
jthomas43
wants to merge
37
commits into
holepunchto:main
from
jthomas43:feature/combined-writes-2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthomas43
requested review from
mafintosh and
kasperisager
and removed request for
mafintosh
January 12, 2024 17:46
…ember of a struct
currently this patch allocates stream packets that look like this: packet_t {...};
uv_buf_t header;
uv_buf_t padding; // placeholder for mtu probe padding. zero length unless mtu probe sent
uv_buf_t data[n]; // payload pointers for n writes
udx_write_t*[]; // udx_write_t pointers for n writes I think I should do another pass to remove the always-allocated |
…end() into single packets with header_flag UDX_HEADER_DATA|UDX_HEADER_END. only set the UDX_HEADER_END bit when the packet carries the last bytes of the write. also sets remote_acked to seq when seq is set with udx_stream_set_seq to prevent RTO for packets taht weren\t sent, and does some debug message cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.