zombie stream keeps libuv loop alive in some cases #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…queues. should fix a bug where a stream is not ended and closed due to NULL's in the udx-fifo retransmit queue
|
lets land this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix use a circular linked list queue for stream in-flight and retransmit queues. the changes were cherry picked from the rack fix branch.
this should fix a bug where a stream is not ended and closed due to NULL's in the udx-fifo retransmit queue. The stream would be kept alive since it appears that the stream still has packets to retransmit, actually the packets were SACKed.