Fix hang when get_next_writable_stream() incorrectly returns a stream already closed #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data that have been closed or destroyed. also updates check_if_streams_have_data to exclude these streams
jthomas43
added a commit
to jthomas43/libudx
that referenced
this pull request
Sep 13, 2024
… already closed (holepunchto#203) * fixes stall due to get_next_writable_stream() returning streams with data that have been closed or destroyed. also updates check_if_streams_have_data to exclude these streams * stricter rules for dead streams, may not send any queued datagram messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes stall that occurs when
get_next_writable_stream()returns a stream that has data, but is closed or destroyed.