Fix bug where stream may close before sending ACK for remote END packet #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d packet for a stream would cause the stream to close before sending the ack to the remote. the solution is to delay setting REMOTE_ENDED until the ack is sent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a stream receives both
in the same on_uv_poll call then the stream will close before sending the ACK for the END packet (1). there are a few solutions possible, this fix moves advancing from UDX_STREAM_ENDING_REMOTE -> UDX_STREAM_ENDED_REMOTE until the ACK to the END packet is sent.