defer adding padding to probe packets to simplify code, fix stream corruption on EAGAIN of packet containing multiple write-buffers #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defers adding an explicit padding buffer to the mtu probe packets until just before the buffers are sent to sendmsg(). This simplifies code that iterates the packets by removing special cases for padding packets.
It more importantly fixes a stream corruption bug on EAGAIN of a packet containing multiple complete wbufs. these wbufs that failed to send would be added back to the stream->write_queue in reverse order, which would corrupt the stream.