-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement building app distributables using pear build
#98
Open
jkcdarunday
wants to merge
70
commits into
main
Choose a base branch
from
feature/pear-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmarkclements
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just throw (then catch and print an error in cmd) if the dir isn't supplied - see how it's done in dump
jkcdarunday
force-pushed
the
feature/pear-build
branch
from
March 28, 2024 20:30
31ea5a9
to
6187482
Compare
Rebased to the latest main branch |
davidmarkclements
force-pushed
the
next
branch
4 times, most recently
from
April 25, 2024 10:45
782f52b
to
c00b6f9
Compare
davidmarkclements
force-pushed
the
next
branch
2 times, most recently
from
May 1, 2024 16:12
d61bf92
to
f2cd5b0
Compare
davidmarkclements
force-pushed
the
next
branch
3 times, most recently
from
May 13, 2024 14:33
5e1f13d
to
cfadb2c
Compare
davidmarkclements
force-pushed
the
next
branch
2 times, most recently
from
May 22, 2024 09:56
966e208
to
f019283
Compare
davidmarkclements
force-pushed
the
next
branch
6 times, most recently
from
May 31, 2024 16:08
31522c6
to
d04ef7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Running
pear build <key> <build directory>
will:bare-dev configure
on the build directorybare-dev build
on the build directoryTesting
assets/linux/icon.png
to exist in the appassets/win32/icon.png
to exist in the appassets/splash.png
to exist in the appassets/darwin/icon.png
to exist in the appassets/splash.png
to exist in the appOther Notes
which
dependency:fs
andpath
in the dependenciesglobal.process
torequire('bare-process')
getuid
andgetgid
functions to return a hardcoded id inglobal.process
as they are not currently implementedpear build <channel>
is not yet supported as I couldn't find a way to resolve channel to key within the clipear dump <key>
seems to print file changes regardless of outputterDependencies