Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @spartan-hc/holo-hash for managing holo-hashes #259

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Use @spartan-hc/holo-hash for managing holo-hashes #259

merged 5 commits into from
Jul 19, 2024

Conversation

mjbrisebois
Copy link
Contributor

Here is a quick example of how we could start using a library to manage holo-hashes while preserving legacy support.

Most of the helper functions in utils could be replaced by the native methods on HoloHash instances.

@mjbrisebois mjbrisebois requested a review from jost-s June 27, 2024 21:55
@mjbrisebois
Copy link
Contributor Author

@jost-s do you see value in this?

jost-s
jost-s reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I do see value in this. Looks good to me

mjbrisebois
mjbrisebois commented Jul 2, 2024
View reviewed changes
src/utils/base64.ts Outdated Show resolved Hide resolved
jost-s
jost-s approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the way to go, use HoloHash | Uint8Array for input to maintain compatibility.

Other than that, the transpiler didn't complain and everything seems to work fine.

src/api/zome-call-signing.ts Show resolved Hide resolved
src/utils/hash-parts.ts Outdated Show resolved Hide resolved
@mjbrisebois mjbrisebois marked this pull request as ready for review July 17, 2024 20:49
@mjbrisebois mjbrisebois requested a review from jost-s July 18, 2024 22:20
@mjbrisebois
Copy link
Contributor Author

Ready to merge then?

@jost-s jost-s merged commit b410db4 into holochain:develop Jul 19, 2024
10 checks passed
@jost-s
Copy link
Contributor

jost-s commented Jul 19, 2024

Yes, thanks for starting this off!

@mjbrisebois mjbrisebois deleted the feat/holo-hash-lib branch July 19, 2024 21:15
@mattyg mattyg mentioned this pull request Jul 31, 2024
Closed
jost-s added a commit that referenced this pull request Aug 5, 2024
@jost-s
Revert "feat: use @spartan-hc/holo-hash for managing holo-hashes (#259)"
aa79f33 
This reverts commit b410db4.
jost-s added a commit that referenced this pull request Aug 5, 2024
@jost-s
revert: @hc-spartan/holo-hash integration (#267)
b46b530 
* Revert "feat: use @spartan-hc/holo-hash for managing holo-hashes (#259)"

This reverts commit b410db4.

* docs: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jost-s jost-s Awaiting requested review from jost-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjbrisebois @jost-s