-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the MQTT option and reconfigure flow #133342
Open
jbouwh
wants to merge
10
commits into
dev
Choose a base branch
from
mqtt-refactor-option-flow
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+479
−371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
breaking-change
cla-signed
core
has-tests
integration: mqtt
labels
Dec 16, 2024
Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
jbouwh
changed the title
Mqtt-refactor-option-flow
Refactor the MQTT option and reconfigue flow
Dec 16, 2024
epenet
changed the title
Refactor the MQTT option and reconfigue flow
Refactor the MQTT option and reconfigure flow
Dec 16, 2024
This was referenced Dec 17, 2024
jbouwh
force-pushed
the
mqtt-refactor-option-flow
branch
from
December 17, 2024 09:12
b87b868
to
5fb4924
Compare
Frontend PR was approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
To reconfigure the MQTT broker settings users need to start a Reconfigure flow. When
CONFIGURE
is selected MQTT show a page "MQTT settings" with subscribe and publish tools. TheRe-configure MQTT
buttton will be replaced with aMQTT options
page. The reconfiguration option will only be available from the MQTT Config Entry context menu.Proposed change
Exclude the MQTT broker setup from the MQTT option flow and move the broker options to the config entry options.
Reconfiguration support was already added with: #132246
The special MQTT config entry page for the MQTT entry needs an update to clarify the MQTT options can be set from there.
Needs:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: