Initial improve thumbnail performance #22238

VandeurenGlenn · 2024-10-04T16:36:48Z

Proposed change

This started as just an improvement to the performance of thumbnails by not inlining them and use an img with lazy loading set instead.
Anyways it turned out to also show images even if no thumbnail is found and changes the img borders to align with ha-card

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (thank you!)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example configuration

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue or discussion:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
There is no commented out code in this PR.
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

see #22226

home-assistant

Hi @VandeurenGlenn

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant · 2024-10-04T16:36:52Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

coderabbitai · 2024-10-04T16:36:54Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

VandeurenGlenn · 2024-10-04T16:40:03Z

Couldn't test locally, goes directly in recovery mode, because of some missing dependencies.

Stale

bramkragten · 2024-10-07T14:00:21Z

https://github.com/home-assistant/frontend/pull/22238/files#diff-43529e22e5fe9147b42da231c5c27fd0f8c534b01f3a3b0529bbfd644a5f5dafR647

Now misses the url() part

bramkragten · 2024-10-07T14:02:48Z

The styling of the images is missing completely, please test this first.

VandeurenGlenn · 2024-10-07T15:48:06Z

https://github.com/home-assistant/frontend/pull/22238/files#diff-43529e22e5fe9147b42da231c5c27fd0f8c534b01f3a3b0529bbfd644a5f5dafR647

Now misses the url() part

Hi @bramkragten Yes, sorry my bad, forgot to put it back to draft, didn't read fully after signing cla.

So the problem is, I can't test local, I was core running succesfully but can't get frontend to work.
I opened a thread on Discord

bramkragten · 2024-12-22T16:47:27Z

src/components/media-player/ha-media-player-browse.ts

+                  ].icon}
+                  slot="graphic"
+                ></ha-svg-icon>
+                ${child.can_play


we checked this on line 646?

Why not move this in the above ternary?

I'll move it

bramkragten · 2024-12-22T17:00:50Z

There are a lot more changes in this PR than just performance, you changed the styling of images (padding and rounded borders) and images are no longer always displayed as squares.

You also added features in your PR, like showing the media file if it is an image in the overview. Not a bad feature, but you don't mention it anywhere (and it should have been a separate PR).

Can you start with filling out the PR template?

VandeurenGlenn · 2024-12-23T09:25:28Z

Hi @bramkragten, yeah my bad, this was one of my first PRs for HA and back then I didn't read the best practices.

VandeurenGlenn · 2024-12-23T16:47:08Z

Accidentally closed this 🙈
Also if you want me to split it up, np!

home-assistant bot previously requested changes Oct 4, 2024

View reviewed changes

home-assistant bot added cla-needed hacktoberfest labels Oct 4, 2024

home-assistant bot marked this pull request as draft October 4, 2024 16:36

home-assistant bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Oct 4, 2024

VandeurenGlenn marked this pull request as ready for review October 4, 2024 17:01

VandeurenGlenn marked this pull request as draft October 7, 2024 15:30

VandeurenGlenn force-pushed the dev branch from d7f31ec to 77ad544 Compare October 11, 2024 17:17

VandeurenGlenn marked this pull request as ready for review October 11, 2024 17:21

VandeurenGlenn force-pushed the dev branch 2 times, most recently from 79e0be4 to 543f053 Compare October 12, 2024 01:32

bramkragten assigned bramkragten and unassigned bramkragten Nov 13, 2024

bramkragten reviewed Dec 22, 2024

View reviewed changes

VandeurenGlenn force-pushed the dev branch from e9f88b7 to 499f05d Compare December 23, 2024 16:25

VandeurenGlenn closed this Dec 23, 2024

VandeurenGlenn force-pushed the dev branch from 499f05d to fc0907e Compare December 23, 2024 16:27

VandeurenGlenn reopened this Dec 23, 2024

VandeurenGlenn force-pushed the dev branch from 980982e to 1ed6543 Compare December 23, 2024 16:41

Update ha-media-player-browse.ts

d3af413

VandeurenGlenn force-pushed the dev branch from 1ed6543 to d3af413 Compare December 25, 2024 07:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial improve thumbnail performance #22238

Initial improve thumbnail performance #22238

VandeurenGlenn commented Oct 4, 2024 •

edited

Loading

home-assistant bot left a comment

home-assistant bot commented Oct 4, 2024

coderabbitai bot commented Oct 4, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

VandeurenGlenn commented Oct 4, 2024

bramkragten commented Oct 7, 2024

bramkragten commented Oct 7, 2024 •

edited

Loading

VandeurenGlenn commented Oct 7, 2024

bramkragten Dec 22, 2024

bramkragten Dec 22, 2024

VandeurenGlenn Dec 23, 2024

bramkragten commented Dec 22, 2024

VandeurenGlenn commented Dec 23, 2024

VandeurenGlenn commented Dec 23, 2024 •

edited

Loading

Initial improve thumbnail performance #22238

Are you sure you want to change the base?

Initial improve thumbnail performance #22238

Conversation

VandeurenGlenn commented Oct 4, 2024 • edited Loading

Proposed change

Type of change

Example configuration

Additional information

Checklist

home-assistant bot left a comment

Choose a reason for hiding this comment

home-assistant bot commented Oct 4, 2024

coderabbitai bot commented Oct 4, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

VandeurenGlenn commented Oct 4, 2024

bramkragten commented Oct 7, 2024

bramkragten commented Oct 7, 2024 • edited Loading

VandeurenGlenn commented Oct 7, 2024

bramkragten Dec 22, 2024

Choose a reason for hiding this comment

bramkragten Dec 22, 2024

Choose a reason for hiding this comment

VandeurenGlenn Dec 23, 2024

Choose a reason for hiding this comment

bramkragten commented Dec 22, 2024

VandeurenGlenn commented Dec 23, 2024

VandeurenGlenn commented Dec 23, 2024 • edited Loading

VandeurenGlenn commented Oct 4, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

bramkragten commented Oct 7, 2024 •

edited

Loading

VandeurenGlenn commented Dec 23, 2024 •

edited

Loading