Fix misleading use of "hidden" and "not shown" for disabled entities #23449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entities can be either hidden (by turning off "Visible") or disabled (by turning off "Enabled"), The stings file uses the very misleading key "hidden_entities" for the count of disabled entities plus the words "not shown" which also pair with "hidden" instead of "disabled". This commit fixes this by using "disabled" for both the key and in the link shown here.
Entities can be either hidden (by turning off "Visible") or disabled (by turning off "Enabled"), The strings file uses the very misleading key "hidden_entities" for the count of disabled entities plus the words "not shown" which also pair with "hidden" instead of "disabled". This commit fixes this by using "disabled" for the key name as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Entities can be just hidden (by turning off "Visible") or completely disabled (by turning off "Enabled"). For hidden entities this is added to the entity name in the Device info page, disabled entities are moved into the collapsed "not shown" section:
Unfortunately the strings file uses the very misleading key "hidden_entities" for the count of disabled entities plus those words "not shown" which also sound much more like "hidden" instead of "disabled".
This results in many completely wrong translations of "not shown" as "hidden". It was the case in German, it still is in Dutch ("entiteiten verborgen") or Italian ("entità nascoste"), e.g.
This PR fixes this by using "disabled" for both the key and in the link shown in the above section. This will automatically remove the wrong use of "hidden" here in all translations.
Personal note: I was completely confused when I started with Home Assistant in German because of that wrong translation of "not shown" as "hidden". It cost me a considerable amount of time to figure out that this was just a misleading wording here and "hidden" entities don't land in that section.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: