Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node and dependencies #1075

Merged
merged 4 commits into from
Oct 25, 2024
Merged

node and dependencies #1075

merged 4 commits into from
Oct 25, 2024

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Oct 12, 2024

  • updated dependencies
  • mark as compatible with node 22

fix type error (probably due to typescript update)

> [email protected] build
> rimraf dist && tsc && node .github/node-persist-ignore.js

src/lib/Accessory.ts:2142:34 - error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
  Type 'undefined' is not assignable to type 'string'.

2142         const version = net.isIP(entry); // check if ip address was specified or an interface name
                                      ~~~~~


Found 1 error in src/lib/Accessory.ts:2142


Process finished with exit code 2

donavanbecker
donavanbecker previously approved these changes Oct 12, 2024
donavanbecker
donavanbecker previously approved these changes Oct 12, 2024
NorthernMan54
NorthernMan54 previously approved these changes Oct 25, 2024
@bwp91 bwp91 dismissed stale reviews from NorthernMan54 and donavanbecker via 2a5d780 October 25, 2024 16:19
@NorthernMan54 NorthernMan54 self-requested a review October 25, 2024 16:29
@bwp91 bwp91 merged commit 31e7391 into latest Oct 25, 2024
13 checks passed
@bwp91 bwp91 deleted the bp/node-22 branch October 25, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants