Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #576

Closed
wants to merge 1 commit into from
Closed

Conversation

n0rt0nthec4t
Copy link

Updated based image to ubuntu 24.04 noble (LTS)
Updated Homebridge APT package to 1.3.10
Updated ffmpeg-for-homebridge to 2.1.7
Updated S6 overlay package to 3.2.0.2

♻️ Current situation

Describe the current situation. Explain current problems, if there are any. Be as descriptive as possible (e.g., including examples or code snippets).

💡 Proposed solution

Describe the proposed solution and changes. How does it affect the project? How does it affect the internal structure (e.g., refactorings)?

⚙️ Release Notes

Provide a summary of the changes or features from a user's point of view. If there are breaking changes, provide migration guides using code examples of the affected features.

➕ Additional Information

If applicable, provide additional context in this section.

Testing

Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?

Reviewer Nudging

Where should the reviewer start? what is a good entry point?

Updated based image to ubuntu 24.04 noble (LTS)
Updated Homebridge APT package to 1.3.10
Updated ffmpeg-for-homebridge to 2.1.7
Updated S6 overlay package to 3.2.0.2
@NorthernMan54
Copy link
Contributor

Homebridge and FFMPEG versions come from here

export HOMEBRIDGE_APT_PKG_VERSION=`get_latest_release "homebridge/homebridge-apt-pkg"`

So changing the version there is irrelevant ( We have portions of the build automated, so it may not be easy to identify

For people currently running the image, and if we change the OS version, is it going to breaking anything for them ? Does this need impact testing before releasing to the world ?

With dependabot, I think I'm going to try this -
image

@n0rt0nthec4t
Copy link
Author

perhaps create a "test" release on docker?

@NorthernMan54
Copy link
Contributor

That's what I'm thinking as well, now does the automation have an option for that, need to look deeper

@n0rt0nthec4t
Copy link
Author

Also, why is S6 overlay used? Seems to make things more complex

@NorthernMan54
Copy link
Contributor

S6 Enables multiple processes ( homebridge, and the various child bridges )

@NorthernMan54
Copy link
Contributor

Local testing is available via test-build-local.sh - it will build an image

What I was concerned about was the plugins that leverage node-gyp and locked to the current OS and NodeJS Release - what happens to those in a users environment when the OS updates

@n0rt0nthec4t
Copy link
Author

Yep, the local test built an image. I think we just have to "break" stuff to move forward. We're running on an outdated OS with known security issues.

@NorthernMan54
Copy link
Contributor

Did you get a moment to try it ? Did it break plugins using node-gyp ?

@n0rt0nthec4t
Copy link
Author

Trie local, and starts up. No what plugins use node-gyp.. still suggest getting a testing tag release going in docker and see feedback from the community?

@NorthernMan54
Copy link
Contributor

I published the current bundle today, and will look at further testing of this next week

@jakepez
Copy link

jakepez commented Dec 10, 2024

Is there an image I can pull? For some reason my docker on my Qnap won't build the image (errors out with dependency problems for systemd, cron-daemon-common).

I'm happy to test if I can pull an image from someone.

@n0rt0nthec4t n0rt0nthec4t closed this by deleting the head repository Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants