Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu:24.04 #579

Merged
merged 1 commit into from
Dec 18, 2024
Merged

ubuntu:24.04 #579

merged 1 commit into from
Dec 18, 2024

Conversation

NorthernMan54
Copy link
Contributor

@NorthernMan54 NorthernMan54 commented Dec 18, 2024

@n0rt0nthec4t @jakepez

So I had some free time today, and finally put this change thru the paces, and it looks really good.

I was able to take a plugin, that used node-gyp, and use the updated Docker ubuntu version without any issues.

Any last comments before I merge this ?

PS - Am still thinking about test versions at some point

@n0rt0nthec4t
Copy link

My only comment would be for the test version, is perhaps start that soon with a homebridge 2.0 one since that’s going to cause issues. Maybe even include config- ui- x 5 as that breaks stuff going by the upcoming warning?

@NorthernMan54
Copy link
Contributor Author

The homebridge-config-ui-x version 5, is due to dropping of support for NodeJS 16 and armv6. Which the docker image is not impacted by. Technically I could update the image to it today.

HB 2.0 is a different discussion though. Am thinking that the end users most impacted would be the low touch people, who would be unlikely to try a test version. And would need to just have a good rollback strategy in place for them. ie how to change docker-compose.yml to use a particular version and not latest.

I had been thinking a lot about new tags, and will be exploring a beta tag shortly.

@NorthernMan54 NorthernMan54 merged commit 3e72c6b into latest Dec 18, 2024
3 checks passed
@NorthernMan54 NorthernMan54 deleted the Update-to-ubuntu-24.04 branch December 18, 2024 20:38
@n0rt0nthec4t
Copy link

Maybe the easiest way is to create a beta branch and do development from there. The GitHub action can push to dockerhub with that branches tag

@NorthernMan54
Copy link
Contributor Author

The challenge is that the Docker image uses homebridge-apt-pkg to install and configure homebridge, so I first need to create a test APT package and go from there.

What I was envisioning was a homebridge-apt-pkg with a BETA flag, which would pickup the latest beta of everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants