-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Allow users to add annotations for refinery and collector deployments #236
chore: Allow users to add annotations for refinery and collector deployments #236
Conversation
…deployments Signed-off-by: suryapandian <[email protected]>
Signed-off-by: suryapandian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suryapandian thanks for this addition. Please remove the changes to the opentelemetry-collector
chart as it is currently being deprecated.
Also please fill out the PR description. |
This reverts commit a2e4967.
Done and removed the collector changes as well. |
Signed-off-by: suryapandian <[email protected]>
Signed-off-by: suryapandian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suryapandian can you post a render of the annotations being applied correctly?
Signed-off-by: suryapandian <[email protected]>
Tested, updated the rendered output in PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which problem is this PR solving?
Allows users to add their custom annotations for refinery and collector deployments.
Short description of the changes
Adds optional deployment annotations to refinery and refinery redis deployments.
How to verify that this has the expected result
Add custom annotations for refinery deployments using
deploymentAnnotations
and custom annotations for refinery redis deployments usingredis.annotations
refinery-redis-deployment-metadata
refinery-deployment-metadata