Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow users to add annotations for refinery and collector deployments #236

Merged
merged 6 commits into from
Apr 27, 2023
Merged

chore: Allow users to add annotations for refinery and collector deployments #236

merged 6 commits into from
Apr 27, 2023

Conversation

suryapandian
Copy link
Contributor

@suryapandian suryapandian commented Apr 18, 2023

Which problem is this PR solving?

Allows users to add their custom annotations for refinery and collector deployments.

  • Closes #

Short description of the changes

Adds optional deployment annotations to refinery and refinery redis deployments.

How to verify that this has the expected result

Add custom annotations for refinery deployments using deploymentAnnotations and custom annotations for refinery redis deployments using redis.annotations

refinery-redis-deployment-metadata

apiVersion: apps/v1
kind: Deployment
metadata:
  name: refinery-redis
  namespace: otel
  labels:
    helm.sh/chart: refinery-1.18.0
    app.kubernetes.io/name: refinery-redis
    app.kubernetes.io/instance: otel-stack
    app.kubernetes.io/version: 1.21.0
    app.kubernetes.io/managed-by: Helm
  annotations:
    linkerd.io/inject: enabled

refinery-deployment-metadata

apiVersion: apps/v1
kind: Deployment
metadata:
 name: refinery
 namespace: otel
 labels:
   helm.sh/chart: refinery-1.18.0
   app.kubernetes.io/name: refinery
   app.kubernetes.io/instance: otel-stack
   app.kubernetes.io/version: 1.21.0
   app.kubernetes.io/managed-by: Helm
 annotations:
   linkerd.io/inject: enabled

@suryapandian suryapandian marked this pull request as ready for review April 18, 2023 13:45
@suryapandian suryapandian requested a review from a team as a code owner April 18, 2023 13:45
Copy link
Contributor

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suryapandian thanks for this addition. Please remove the changes to the opentelemetry-collector chart as it is currently being deprecated.

@TylerHelmuth
Copy link
Contributor

Also please fill out the PR description.

@suryapandian
Copy link
Contributor Author

Also please fill out the PR description.

Done and removed the collector changes as well.

@suryapandian suryapandian changed the title EOPS-1547: Allow users to add annotations for refinery and collector deployments Allow users to add annotations for refinery and collector deployments Apr 18, 2023
Signed-off-by: suryapandian <[email protected]>
Copy link
Contributor

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suryapandian can you post a render of the annotations being applied correctly?

charts/refinery/templates/deployment-redis.yaml Outdated Show resolved Hide resolved
Signed-off-by: suryapandian <[email protected]>
@suryapandian
Copy link
Contributor Author

suryapandian commented Apr 18, 2023

@suryapandian can you post a render of the annotations being applied correctly?

Tested, updated the rendered output in PR description.

@suryapandian suryapandian changed the title Allow users to add annotations for refinery and collector deployments chore: Allow users to add annotations for refinery and collector deployments Apr 19, 2023
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerHelmuth TylerHelmuth merged commit fe88950 into honeycombio:main Apr 27, 2023
@suryapandian suryapandian deleted the user-annot-deploy branch April 28, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants