fix: escape according to value types #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodie
force-pushed
the
feature/value-types
branch
2 times, most recently
from
fb07391 to
c65fe71
Compare
hoodie
force-pushed
the
feature/value-types
branch
2 times, most recently
from
21c0ed8 to
96d3e0d
Compare
this fixes #104 (introduced in 0.16.2) where URL properties got unnecessarily escaped
hoodie
force-pushed
the
feature/value-types
branch
from
96d3e0d to
156177d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now look determine the value-type of a property (either by name or parameter) and escape/unescape accordingly.
This fixes #104
At the moment this only distinguishes between
TEXTand non-TEXT, but technically the value type should also be considered when parsing dates vs durations etc.