fix: remove colon escape in text property #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Omg thanks. Seems I overlooked this. I'll give it a closer look tonight. |
|
could you perhaps help me with an example that I could turn into a test? |
|
Went ahead and added a unit test myself 😃 |
|
And now it actually works as I'd expect that test to work, sorry about those force pushes 😅 |
|
cool thanks. testing escaping of text is such a confusing matter |
|
@good-praxis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #111, COLONs should not be escaped with a BACKSLASH in a TEXT property (capitalization to match the spec).
This removes the line I found that was doing it, a quick test run generated a valid ical file based on my usecase (as validated via https://icalendar.org/validator.html)
All tests still pass. I'm however unfamiliar with the code base and my usecase is limited in complexity, so please double check me