Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add type conversion DatePerhapsTime <-> NaiveDate #119

Merged
merged 1 commit into from
Nov 30, 2024
Merged

feat: add type conversion DatePerhapsTime <-> NaiveDate #119

merged 1 commit into from
Nov 30, 2024

Conversation

arichtman
Copy link
Contributor

Refs: #118

@ThomasdenH
Copy link
Contributor

Since this may discard time zone information, would it be worth turning this into a method date_naive? That would avoid a situation where someone forgets to homogenize the time zone before converting to a date. This would mirror DateTime::date_naive for example.

@arichtman arichtman force-pushed the naivedate-conversion branch from 8a4e353 to 7acd8ff Compare November 17, 2024 12:51
@arichtman
Copy link
Contributor Author

Great point. How's this ? Also, should I add some tests?

@hoodie hoodie merged commit 5a3d8b5 into hoodie:main Nov 30, 2024
@hoodie
Copy link
Owner

hoodie commented Nov 30, 2024

thanks for you contribution, I just published v0.16.10

@arichtman arichtman deleted the naivedate-conversion branch November 30, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arichtman @ThomasdenH @hoodie