Support for Laravel 5.8 #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fire method (which was deprecated in Laravel 5.4) of the Illuminate/Events/Dispatcher class has been removed. You should use the dispatch method instead.
add php 7.2 env
|
I can confirm this PR fixes the event fire error. |
|
I got the same issue while trying to upgrade to Laravel 5.8 and the PR fix it. Will it be available soon? |
joacorob
approved these changes
Jun 24, 2019
|
Approved but not merged....? |
|
Any movement on this @hootlex? Thanks! |
|
Some news about the pull request? |
|
@hootlex hoping for a merge for Laravel 5.8 support! |
|
Is the repo still maintained? Did someone else take over? |
|
@kainxspirits - might as well update this PR to add Laravel 6.0 support as well ;) |
|
@hootlex Please fill in these edits to support new versions of laravel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already made a PR on MoeCasts fork, but it might be quicker to just make a new PR here.
You can delete this PR if another fix is merged.
Next version should probably be 1.1, since we drop support for previous php version.