feat: re-export external types from the API as part of the API #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
requested review from
datanel,
patochectp,
ArnaudOggy and
pbench
woshilapin
force-pushed
the
expose-typed-index-collection
branch
from
30821c0 to
e32a012
Compare
pbench
previously approved these changes
Sep 26, 2023
woshilapin
force-pushed
the
expose-typed-index-collection
branch
4 times, most recently
from
7947864 to
5e8094a
Compare
|
Fell free to move forward or close this PR. Since I won't be working on it anymore, I might close it if nothing happened at some point in the future. |
datanel
force-pushed
the
expose-typed-index-collection
branch
from
5e8094a to
10c35a7
Compare
datanel
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, all users of
transit_modelcan't depend only ontransit_modelin theirCargo.tomlbecause if one of the API returns aNaiveDate, or anyIdx, the use basically needs to also importchronoandtyped_index_collection. On top of that, it must find and import the exact same version of the dependency that the one declared intransit_model(or else, might face compilation errors).Let's be more explicit on the API we expose. Note that I did not make an exhaustive research of all the things that we must re-export, only a brief dive to catch most of them. It's a step forward, might not be a perfect step though 🤷