Fix Heroku deploys

[cmfcmf]

Probably due to a Postgres update, the database now is more restrictive when it comes to changing a column's type. The Heroku deployment failed for this reason. I have already confirmed this fix to be working by manually applying it to the currently deployed version. You'll see it running over here: http://workshopportal.herokuapp.com/

Things left to do:

• Verify this doesn't break SQLite migrations. (i.e. destroy your SQLite database and see if rake db:migrate works afterwards)

[bjrne]

Brilliant catch! 💾
rake migrate doesn't work at the moment due to the error 2 is out of range for ActiveRecord::Type::Integer with limit 0. I can fix this later.
I opened an issue for the remaining tasks, #655.

[bjrne]

Should we really run migrations on deployment? Shouldn't we rather use db:setup in the release version? If we want to see whether it succeeds I'd rather write a test (if possible) that tries migrating with postgres.

[bjrne]

Depending on when this setting applies we might want to add db:populate_sample_data

[cmfcmf]

Oh, right!
I'll add more info soon.

[coveralls]

Coverage remained the same at 100.0% when pulling 538f7f1 on fix-heroku into 288494c on dev.

[cmfcmf]

This is called once on a review app whenever a new merge request - and a review app - is created.

[cmfcmf]

This is called "all the time" on review apps as well as on the dev deployment. As per the docs, this is called after:

• An app build
• A config var set by a user
• A pipeline promotion
• A rollback
• A release via the platform API

I figured it would make sense to run migrations so the dev is always up to date.

[bjrne]

The only time it doesn't make sense to me is a rollback. Wouldn't you need to call rake db:rollback accordingly then? Given that a migration was added in that code, you'd want to change that back as well, wouldn't you? Or does rollback refer to a step back in the pipeline (like from dev to staging)? And if that is the case, in this example is this then called on the dev or the staging pipeline step?

[cmfcmf]

I think rollback means that you deploy an old commit over the current commit. I agree migrating is the wrong approach then. However, I see no other way to solve this currently. I think we should ignore this edge case.

[coveralls]

Coverage remained the same at 100.0% when pulling 79ec56d on fix-heroku into 87ef775 on dev.

[bjrne]

So finally: Works and should be merged asap ☝️

[coveralls]

Coverage remained the same at 100.0% when pulling 9e65724 on fix-heroku into 2f5695c on dev.