Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make DepthAnythingV2 more reusable #2675

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

edgarriba
Copy link
Contributor

This pull request includes changes to the candle-examples and candle-transformers projects to improve memory management and simplify the codebase. The most important changes involve the use of Arc for shared ownership and the removal of lifetime parameters in the DepthAnythingV2 and DPTHead structures.

Improvements to memory management:

Codebase simplification:

These changes enhance the code's readability and maintainability while improving memory management through shared ownership.

@LaurentMazare LaurentMazare merged commit 5c2f893 into huggingface:main Dec 21, 2024
10 checks passed
@LaurentMazare
Copy link
Collaborator

Thanks!

@edgarriba
Copy link
Contributor Author

@LaurentMazare afer this first contribution, I realized that you don't have any command to run the whole dev-test (clippy,fmt,etc).

A useful tool for that would be just -- https://github.com/casey/just

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants