Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add final benchmarks on A100 #121

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Add final benchmarks on A100 #121

merged 7 commits into from
Mar 15, 2024

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Mar 15, 2024 •
edited by dacorvo
Loading

Some perplexity numbers were still based on the old script.

@younesbelkada younesbelkada marked this pull request as ready for review March 15, 2024 08:55
@younesbelkada younesbelkada requested a review from dacorvo as a code owner March 15, 2024 08:55
@younesbelkada
Copy link
Contributor Author

cc @dacorvo

dacorvo
dacorvo reviewed Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chart for zephy latency seems wrong: this is the only one for which latency has increased (a lot !!!). Can you remove it ?

@younesbelkada
Copy link
Contributor Author

Ah yes ! Done !

@younesbelkada younesbelkada requested a review from dacorvo March 15, 2024 09:04
dacorvo
dacorvo previously approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice, love the gemma numbers, thanks !

@younesbelkada
Copy link
Contributor Author

sorry, just let me change something

@younesbelkada
Copy link
Contributor Author

Done !

@younesbelkada younesbelkada requested a review from dacorvo March 15, 2024 09:06
@dacorvo dacorvo merged commit f3389c0 into main Mar 15, 2024
1 check passed
@dacorvo dacorvo deleted the younesbelkada-add-bench branch March 15, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacorvo dacorvo dacorvo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@younesbelkada @dacorvo