Refactor tensors #147
Merged
Refactor tensors #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better separates the responsibilities between Tensor subclasses and their quantizers. It also creates dedicated quantize_weight and quantize_activation helper to better illustrate the differences between the two quantized Tensor types.
dacorvo
force-pushed
the
refactor_tensors
branch
4 times, most recently
from
c77b612 to
cb66d7a
Compare
dacorvo
force-pushed
the
refactor_tensors
branch
from
cb66d7a to
ff791c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the distinction between quantized activations (8-bit per-tensor only) and quantized weights (per-axis) clearer.