Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: investigate why extensions are not compiled #253

Closed
wants to merge 6 commits into from

Conversation

dacorvo
Copy link
Collaborator

@dacorvo dacorvo commented Jul 23, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you run all tests locally and make sure they pass.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@dacorvo dacorvo force-pushed the investigate_ci_compilation_issues branch 2 times, most recently from 0927c43 to 763a962 Compare July 23, 2024 07:26
@dacorvo dacorvo force-pushed the investigate_ci_compilation_issues branch from 763a962 to a5efa20 Compare July 23, 2024 07:46
@dacorvo dacorvo force-pushed the investigate_ci_compilation_issues branch from a5efa20 to 34e76f3 Compare July 23, 2024 07:51
@dacorvo dacorvo force-pushed the investigate_ci_compilation_issues branch from a4f0fee to 92fb18c Compare July 23, 2024 08:19
@dacorvo dacorvo force-pushed the investigate_ci_compilation_issues branch from 12e67cd to b5e8b39 Compare July 23, 2024 08:53
@dacorvo
Copy link
Collaborator Author

dacorvo commented Jul 23, 2024

We need to install the package in editable mode, because if we deploy it from a temporary package setuptools_scm does not recognize the cpp source files and they are not included in the temporary package (see #254).

@dacorvo dacorvo closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant