Remove package.json lint rule for no devdeps #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is because the This just hasn't happened yet and is why this rule is only set to Line 38 in 9aedd9d E.g. via https://app.travis-ci.com/github/humanmade/coding-standards/jobs/578616221#L262-L270
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
npm-package-json-lintto check that our package.json files comply with certain rules.One of these rules is configured so that you are not allowed to use
devDependenciesin the packages, but it's OK at the top-level. However this test fails because we have devDependencies in the eslint config package.Seems to me that we should just disable this rule. I'm not sure why it has ever passed TBH.