chore(server): Vendor hyper-util graceful shutdown feature #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
graceful-shutdown
branch
2 times, most recently
from
590b928 to
639fe98
Compare
tottoto
force-pushed
the
graceful-shutdown
branch
3 times, most recently
from
e719f64 to
91086e1
Compare
tottoto
force-pushed
the
graceful-shutdown
branch
2 times, most recently
from
af476f2 to
1b8ce06
Compare
tottoto
force-pushed
the
graceful-shutdown
branch
5 times, most recently
from
969bc13 to
6fb4b18
Compare
tottoto
changed the title
tottoto
force-pushed
the
graceful-shutdown
branch
from
6fb4b18 to
d624e10
Compare
|
Why/how is this an improvement? |
tottoto
force-pushed
the
graceful-shutdown
branch
from
d624e10 to
815df41
Compare
|
Centralizing the graceful shutdown implementation and using it at server implementation can split their responsibility and improve the maintainability. |
|
But this is duplicating the entire thing... that doesn't seem like centralizing in a meaningful way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
hyper_util::server::graceful::GracefulShutdownto implement graceful shutdown.