fix: node_version check for the fabric-shim #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzikowski
reviewed
Apr 12, 2024
src/setup-docker/templates/fabric-docker/scripts/chaincode-functions-v2.sh
Outdated
Show resolved
Hide resolved
|
Hey @dzikowski sorry for not responding for last 2 weeks my exams were going on meanwhile. I have done the changes. I hope this will do the job |
dzikowski
reviewed
Apr 29, 2024
src/setup-docker/templates/fabric-docker/scripts/chaincode-functions-v2.sh
Outdated
Show resolved
Hide resolved
dzikowski
reviewed
May 7, 2024
src/setup-docker/templates/fabric-docker/scripts/chaincode-functions-v2.sh
Outdated
Show resolved
Hide resolved
|
Please add DCO signoff |
dzikowski
reviewed
May 7, 2024
e2e/__snapshots__/fablo-config-hlf1.3-2orgs-1chaincode-private-data.json.test.ts.snap
Outdated
Show resolved
Hide resolved
|
hey @dzikowski I think there's some issue with private data test it fails everytime I hope this is the relevant issue for it - #396 . let me know I'll try to fix it. |
|
Yes, that's the relevant issue. Feel free to start, thanks! A simple removal of the check and the sh script is enough for the first PR. Update test-02 to contain private data chcecks should be performed separately |
…the versions for fabric shim Signed-off-by: Sanket <[email protected]> added the snapshots Signed-off-by: Sanket <[email protected]> suggest recommended node Signed-off-by: Sanket <[email protected]> reafactored the code to avoid the breaking due to import of v1.4 added the snapshots fixed the function, now it is returning the proper required version Signed-off-by: Sanket Teli <[email protected]> Update src/setup-docker/templates/fabric-docker/scripts/chaincode-functions-v2.sh Co-authored-by: Jakub Dzikowski <[email protected]> Signed-off-by: Sanket Teli <[email protected]> changes the directory location Signed-off-by: Sanket Teli <[email protected]> added snapshots Signed-off-by: Sanket Teli <[email protected]>
Sanket-0510
force-pushed
the
fabric-shim
branch
from
2ce9502 to
08e6a29
Compare
Signed-off-by: Sanket Teli <[email protected]>
Signed-off-by: Sanket Teli <[email protected]>
dzikowski
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #325
I have refactored the code so that it will resolve the issue #325, now we will be checking fabric version in
node_modules/fabric-shim/package.jsoninstead of./package.jsonalso it will recommend the correct updated node_version for the fabric-shim