Improvements for docker user management and documentation #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker reports this statement as deprecated. Signed-off-by: Mic Bowman <[email protected]>
Just trying to make consistent our use of the user name we create. This makes the user name the same across all images and makes sure it is being used in the right places. Some tinkering with the caches we use for the RUN statements. Dropped the UID (there is very little documentation about how this actually affects the cache and whose UID it is) so we'll use the default. Added cache statements for apt statements as well. Note that for good connections, the caching does not make a measurable difference in the time to build. It could be that we are still not using the cache appropriately. Signed-off-by: Mic Bowman <[email protected]>
Signed-off-by: Mic Bowman <[email protected]>
cmickeyb
force-pushed
the
mic.dec12.docker_user_id
branch
from
39a709b to
9fc98d6
Compare
g2flyer
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the user and group creation in the docker build. An account and group are created in the base images and then used more consistently throughout the rest of the build process.
Added documentation for how to build and deploy "reusable" images that might be store, for example, in a public registry. This information should make it easier to use the images being built on github.
There are also some additions the docker cache for apt packages.
Testing: automated tests should handle the changes to the docker build scripts. The instructions in the docker README.md for building deployable images (the final pattern) should be verified.