Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "revert guice7 to guice6" #249

Closed
wants to merge 1 commit into from
Closed

Revert "revert guice7 to guice6" #249

wants to merge 1 commit into from

Conversation

surajpuvvada
Copy link
Contributor

Reverts #248

@surajpuvvada surajpuvvada requested a review from a team as a code owner October 25, 2024 15:50
@github-actions GitHub Actions
Copy link

Test Results

134 tests  ±0   134 ✅ ±0   1m 2s ⏱️ +2s
 31 suites ±0     0 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit 1d0b65b. ± Comparison against base commit 3088579.

aaron-steinfeld
aaron-steinfeld requested changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original revert was correct. We do not want guice 7 here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-steinfeld aaron-steinfeld aaron-steinfeld requested changes

@Vaibhav090420 Vaibhav090420 Awaiting requested review from Vaibhav090420

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surajpuvvada @aaron-steinfeld