Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert document store createOrReplace api #257

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

bhubam
Copy link
Contributor

@bhubam bhubam commented Nov 26, 2024

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@bhubam bhubam requested a review from a team as a code owner November 26, 2024 05:55
Copy link

github-actions bot commented Nov 26, 2024

Test Results

134 tests  ±0   134 ✅ ±0   1m 0s ⏱️ -1s
 31 suites ±0     0 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit f5eb98c. ± Comparison against base commit ff9afcf.

♻️ This comment has been updated with latest results.

@bhubam
Copy link
Contributor Author

bhubam commented Nov 26, 2024

https://github.com/hypertrace/config-service/pull/255/files?file-filters%5B%5D=.java&show-viewed-files=true#r1851946346, we have a usecase were value starts with $ (ex: were we provide jsonpath as input, it starts with $) cc @suresh-prakash @harshit-kumar-v2

@harshit-kumar-v2
Copy link
Contributor

https://github.com/hypertrace/config-service/pull/255/files?file-filters%5B%5D=.java&show-viewed-files=true#r1851946346, we have a usecase were value starts with $ (ex: were we provide jsonpath as input, it starts with $) cc @suresh-prakash @harshit-kumar-v2

This is issue with this new api, please file a bug with the log.

@bhubam bhubam enabled auto-merge (squash) November 26, 2024 06:08
avinashkolluru
avinashkolluru previously approved these changes Nov 26, 2024
@aaron-steinfeld
Copy link
Contributor

Overriding dep check for this PR as NVD is currently unavailable.

@aaron-steinfeld aaron-steinfeld merged commit 681e7e5 into main Nov 26, 2024
8 checks passed
@aaron-steinfeld aaron-steinfeld deleted the revert-to-document-store-api branch November 26, 2024 15:48
@aaron-steinfeld
Copy link
Contributor

(oops forgot to approve - approved :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants