-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade service framework to support jakarta (JEE 9) #109
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
============================================
+ Coverage 68.21% 68.53% +0.32%
Complexity 107 107
============================================
Files 17 17
Lines 623 623
Branches 32 32
============================================
+ Hits 425 427 +2
+ Misses 179 177 -2
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Change looks fine - I wonder if we should change the artifact name/group? |
I think we can go with new name to go a systematic route. If i am missing something can you also briefly describe how we should move the changes. |
I think we're saying the same thing? New, unique artifact so it doesn't conflict with the existing ones. We don't need to maintain the old lineage, we just want to avoid the transitive upgrade. |
yeah, just iterating over again to be sure. |
57ca21e
to
87ecd60
Compare
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.