Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade service framework to support jakarta (JEE 9) #109

Merged
merged 8 commits into from
Dec 22, 2024

Conversation

harshit-kumar-v2
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

Copy link

github-actions bot commented Nov 22, 2024

Test Results

32 tests  ±0   32 ✅ ±0   14s ⏱️ +5s
 9 suites ±0    0 💤 ±0 
 9 files   ±0    0 ❌ ±0 

Results for commit e577182. ± Comparison against base commit 100e1a7.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.53%. Comparing base (100e1a7) to head (e577182).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #109      +/-   ##
============================================
+ Coverage     68.21%   68.53%   +0.32%     
  Complexity      107      107              
============================================
  Files            17       17              
  Lines           623      623              
  Branches         32       32              
============================================
+ Hits            425      427       +2     
+ Misses          179      177       -2     
  Partials         19       19              
Flag Coverage Δ
unit 68.53% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-kumar-v2 harshit-kumar-v2 marked this pull request as ready for review November 22, 2024 10:55
@harshit-kumar-v2 harshit-kumar-v2 requested a review from a team as a code owner November 22, 2024 10:55
@harshit-kumar-v2 harshit-kumar-v2 changed the title Upgrade service framework Move service framework to support jakarta (JEE 9) Nov 22, 2024
@harshit-kumar-v2 harshit-kumar-v2 changed the title Move service framework to support jakarta (JEE 9) Upgrade service framework to support jakarta (JEE 9) Nov 22, 2024
@aaron-steinfeld
Copy link
Contributor

Change looks fine - I wonder if we should change the artifact name/group?

@harshit-kumar-v2
Copy link
Contributor Author

Change looks fine - I wonder if we should change the artifact name/group?

I think we can go with new name to go a systematic route.
I suppose we will add new artifact to bom and start consuming in our upgraded services one-by-one?
This will also help us do compatibility changes on services with upgrade SF.

If i am missing something can you also briefly describe how we should move the changes.

@aaron-steinfeld
Copy link
Contributor

I think we can go with new name to go a systematic route.
I suppose we will add new artifact to bom and start consuming in our upgraded services one-by-one?

I think we're saying the same thing? New, unique artifact so it doesn't conflict with the existing ones. We don't need to maintain the old lineage, we just want to avoid the transitive upgrade.

@harshit-kumar-v2
Copy link
Contributor Author

harshit-kumar-v2 commented Dec 2, 2024

I think we can go with new name to go a systematic route.
I suppose we will add new artifact to bom and start consuming in our upgraded services one-by-one?

I think we're saying the same thing? New, unique artifact so it doesn't conflict with the existing ones. We don't need to maintain the old lineage, we just want to avoid the transitive upgrade.

yeah, just iterating over again to be sure.
i will make this change then.
EDIT: is there any conf we can add or just renaming the modules will allow us to achieve this?

@harshit-kumar-v2 harshit-kumar-v2 force-pushed the upgrade-service-framework branch from 57ca21e to 87ecd60 Compare December 6, 2024 15:05
kotharironak
kotharironak previously approved these changes Dec 22, 2024
@harshit-kumar-v2 harshit-kumar-v2 merged commit eb17102 into main Dec 22, 2024
6 checks passed
@harshit-kumar-v2 harshit-kumar-v2 deleted the upgrade-service-framework branch December 22, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants