Convert Node scripts to module scripts #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
commented
Apr 15, 2024
| @@ -5,10 +5,11 @@ | |||
| * file and the package environment. | |||
| */ | |||
|
|
|||
| 'use strict'; | |||
| import * as fs from 'node:fs'; | |||
| import * as path from 'node:path'; | |||
There was a problem hiding this comment.
While writing this I realized we didn't have a convention about whether to use the node: prefix or not and whether it was considered preferred practice. nodejs/node#38343 suggests that using the prefix for built-in modules is preferred.
There was a problem hiding this comment.
I think the prefix makes sense.
This reduces the need for variation in eg. linting rules by making all JS files modules where possible. Note that Karma does not support this. See karma-runner/karma#3677.
robertknight
force-pushed
the
use-module-scripts
branch
from
55e20c1 to
595d1f0
Compare
acelaya
approved these changes
Apr 15, 2024
| @@ -5,10 +5,11 @@ | |||
| * file and the package environment. | |||
| */ | |||
|
|
|||
| 'use strict'; | |||
| import * as fs from 'node:fs'; | |||
| import * as path from 'node:path'; | |||
There was a problem hiding this comment.
I think the prefix makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the need for variation in eg. linting rules by making all JS files modules where possible. Note that Karma does not support this. See karma-runner/karma#3677.