Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM modules & More #2285

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

Scavanger
Copy link
Contributor

@Scavanger Scavanger commented Dec 15, 2024

Actually it should be ‘only’ due to support from ESM, but somehow it has become a major maintenance update, the Configurator should now really be fit for the next few years.

  • Complete switch to ESM modules
  • Vite as module bundler and dev server
  • Assets partially renamed, moved and converted to be compatible with vite
  • iOS7 switch library ‘switchery’ replaced by a pure CSS variant, because not ESM compatible.
  • Updated some npm modules
  • Removal of (almost) all static libraries and replacement by corresponding npm modules
  • ‘Accidentally’ fixed minor bugs / layout problems ;)

Bonus: The packed installers/archives are now about 40 Mb smaller.

Known issues:
Elevation graph in Misson control not working, graph lib incompatible with vite.
Will be fixed in Missionplanner rewrite.

@mmosca mmosca added this to the 9.0 milestone Dec 15, 2024
@Scavanger
Copy link
Contributor Author

Tested under Windows and Linux, looks good so far.
Maybe someone can take another look and check if I have overlooked something. :)

@Scavanger Scavanger marked this pull request as ready for review December 18, 2024 01:09
@stronnag
Copy link
Collaborator

Lightly "tested" on Arch Linux

@Scavanger
Copy link
Contributor Author

Scavanger commented Dec 18, 2024

@stronnag

Lightly "tested" on Arch Linux

  • Neccesary to run npm install --save-dev @electron-forge/plugin-vite`

Make sure to do a npm update after checkout the new branch

Works for me on Kubuntu 24.10/X11 and propetary NVIDIA drivers.
Do you have any usefull error messages when running in dev mode?
Edit: I disabled 3D acceleration for linux, should work on all linux systems now, but makes the 3D animations sluggish.
electron/electron#32760

  • Mission control does not load at all (may be part of "Known issues")

Fixed, (wrong filename of an asset)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants