Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed some unnecessary preset parameters for FW #2287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

b14ckyy
Copy link
Collaborator

@b14ckyy b14ckyy commented Dec 19, 2024

Removed some Preset values for Fixed wings due to FW changes that will be good on defaults.
Comes along with iNavFlight/inav#10541

@b14ckyy b14ckyy added this to the 8.0 milestone Dec 19, 2024
@mmosca
Copy link
Collaborator

mmosca commented Dec 19, 2024

Maybe instead of removing these, just adjust the airplane without a tail values as bredoven recommendations? We can look into removing this later, with more time for testing.

@b14ckyy
Copy link
Collaborator Author

b14ckyy commented Dec 19, 2024

If the controller now controls velocity and not position, I think the difference in wing load and pitch authority should not make a difference between them anymore. What is breadoven's recommendation? Could not see that in the 2 threads I follow. If they still act differently then yes I can add them back in with slightly different values.

@breadoven
Copy link
Collaborator

If the controller now controls velocity and not position, I think the difference in wing load and pitch authority should not make a difference between them anymore. What is breadoven's recommendation? Could not see that in the 2 threads I follow. If they still act differently then yes I can add them back in with slightly different values.

I don't see any reason why the velocity altitude control would affect the xy position control so these values should be left unchanged.

@b14ckyy
Copy link
Collaborator Author

b14ckyy commented Dec 19, 2024

@breadoven I removed the xy presets in that go as well since I noticed that somewhere in the 7.0 or 7.1 phase the value for flying wings with no tail was too low. I planned to change/remove them for a while and just remembered so I removed them now.
Especially I noticed with Path tracking and Autoland, that Wings struggle to get a precise heading fast enough on 55 while the Tail Planes worked much better. 75 or more on wings was severely better in tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants