[chore/Feature2Mesh] factorize featureTo family of function #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring Feature and Feature2Mesh to improve software architecture and add styling points feature. Software architecture * move Style responsibility from Feature to Feature2Mesh, because no stylisation must be applied when parsing. * add FeatureContext class to encapsulate all properties and methods necessary for stylization.
Desplandis
force-pushed
the
factorize_featureTo
branch
from
d69941e to
71f8ccf
Compare
|
Won't be finished soon so closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up of #2180.
Refactoring
Feature2Meshto reduce duplication of code.Motivation and Context
There is lot of duplicated code in the
featureTo*family of functions:featureToPointfeatureToLinefeatureToPolygonfeatureToExtrudedPolygonsThis leads to potential bugs, out-of-sync code (e.g. between
featureToPolygon*functions) and does not ease maintenance of this module.This PR aims to generalize code of both functions (e.g. at least
featureToPoint/featureToLine&featureToPolygon/featureToExtrudedPolygons).