refactor: migrate Extent to typescript #2444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desplandis
force-pushed
the
ts-migration/extent
branch
2 times, most recently
from
dd973a3 to
e0ec527
Compare
Desplandis
force-pushed
the
ts-migration/extent
branch
from
e0ec527 to
870d50b
Compare
BREAKING CHANGE: - Remove deprecated Extent#dimensions method
BREAKING CHANGE: - Deprecate Extent#constructor with array and extent parameters - Deprecate Extent#set with array and extent parameters
Desplandis
force-pushed
the
ts-migration/extent
branch
from
870d50b to
88ad67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
Extentfrom javascript to typescriptdimensionssetFromArrayandsetFromExtentmethodsProposed breaking type changes:
Three.VectorAPI, I propose that the constructor ofExtentonly accepts numbers as parameters. We could set from array, coordinates-like objects from corresponding methodssetFromArrayorsetFromExtent. Note that for js users, we would not for now break compatibility (and add a depreciation notice).Motivation and Context
As described in proposal #2396, we aim to gradually migrate our entire codebase (with the exception of deprecated modules) from javascript to typescript. We choose to start with modules with no-dependency and move up in the dependency tree.
This PR is the third step of Migrate geographic modules, migrating the
Extentmodule. This PR is a follow-up of #2437.