Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting composite EC properties to null #688

Merged
merged 25 commits into from
Jul 4, 2024
Merged

Allow setting composite EC properties to null #688

merged 25 commits into from
Jul 4, 2024

Conversation

6ar8nas
Copy link
Contributor

@6ar8nas 6ar8nas commented Mar 25, 2024 •
edited
Loading

itwinjs-core: iTwin/itwinjs-core#6884

The changes test for different updating to null struct and array behaviors through various updating mechanisms and fixes updating a prefilled ECInstance from a JSON value through handling null cases.

Closes iTwin/itwinjs-backlog#1057

@6ar8nas 6ar8nas mentioned this pull request Mar 25, 2024
Draft
@6ar8nas 6ar8nas marked this pull request as ready for review March 25, 2024 09:32
@6ar8nas
Copy link
Contributor Author

6ar8nas commented Mar 25, 2024

/azp run imodel-native

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@khanaffan
Copy link
Contributor

Following test are failing

[  FAILED  ] ECInstanceInserterTests.InsertSingleInstanceOfComplexClass
[  FAILED  ] ECInstanceInserterTests.InsertSingleRuleInstance
[  FAILED  ] ECSqlStatementTestFixture.StructUpdateWithDotOperator
[  FAILED  ] ECSqlStatementTestFixture.WriteCalculatedECProperty

@6ar8nas 6ar8nas marked this pull request as draft March 25, 2024 15:21
@6ar8nas 6ar8nas closed this Apr 15, 2024
@6ar8nas 6ar8nas deleted the Sarunas/struct-handling-null branch April 15, 2024 16:14
@6ar8nas 6ar8nas restored the Sarunas/struct-handling-null branch June 19, 2024 09:02
@6ar8nas 6ar8nas reopened this Jun 19, 2024
@6ar8nas 6ar8nas mentioned this pull request Jun 20, 2024
Merged
@6ar8nas 6ar8nas marked this pull request as ready for review June 26, 2024 13:18
@6ar8nas 6ar8nas requested a review from c-macdonald as a code owner June 26, 2024 13:18
@6ar8nas 6ar8nas changed the title Allow setting struct property to null Allow setting composite EC properties to null Jun 28, 2024
@6ar8nas
Copy link
Contributor Author

6ar8nas commented Jun 28, 2024

/azp run imodel-native

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@6ar8nas 6ar8nas requested a review from rschili June 28, 2024 15:07
@6ar8nas 6ar8nas enabled auto-merge (squash) July 3, 2024 14:56
@6ar8nas 6ar8nas merged commit b449aa3 into main Jul 4, 2024
18 checks passed
@6ar8nas 6ar8nas deleted the Sarunas/struct-handling-null branch July 4, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschili rschili rschili approved these changes

@khanaffan khanaffan khanaffan approved these changes

@pmconne pmconne Awaiting requested review from pmconne pmconne is a code owner

@calebmshafer calebmshafer Awaiting requested review from calebmshafer calebmshafer is a code owner

@ColinKerr ColinKerr Awaiting requested review from ColinKerr ColinKerr is a code owner

@c-macdonald c-macdonald Awaiting requested review from c-macdonald c-macdonald is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@6ar8nas @khanaffan @rschili