-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function findElementClassId #753
base: main
Are you sure you want to change the base?
Conversation
You do not need a function for it. You can do it with ECSQL
|
Would this work in the cases where transformations define their own remappings from sourceClassFullName to targetClassFullName? The most recent example we saw was with an iModel which had some linearDraft changesets which introduce a lot of unnecessary schemas. The source iModel would have a schema like IUQYJHLAL:WireSupport, which would be remapped to the target iModel's schema ConsolidatedWireSupport:WireSupport. |
No it will not do that. I meant if you want to convert className to id from typescript side. So if you have map for className available on typescript side then you can do the conversion their instead of adding native method. Our goal should be bringing more logic into typescript when possible and slim out native layer. |
The map for className available on the typescript side doesn't exist. Right now it goes directly to the native side by calling 'transformer.context.remapElementClass'. Native side converts the classFullName into a classId. I suppose we could add a method to transformer in TS |
as issue 173, we need to export findRemappedElementClass, this PR is for the corresponding part on native side