IBX-8470: Upgraded codebase to Symfony 6 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Nov 25, 2024
konradoboza
reviewed
Nov 28, 2024
| @@ -42,24 +42,21 @@ public function process(ContainerBuilder $container) | |||
| $container->setAlias(ContentTagInterface::class, 'fos_http_cache.http.symfony_response_tagger'); | |||
| } | |||
|
|
|||
| public static function getTaggedService(ContainerBuilder $container, $tag) | |||
| public static function getTaggedService(ContainerBuilder $container, $tag): string|null | |||
There was a problem hiding this comment.
Suggested change
| public static function getTaggedService(ContainerBuilder $container, $tag): string|null | |
| public static function getTaggedService(ContainerBuilder $container, $tag): ?string |
There was a problem hiding this comment.
Is this function being public intentional? It seems to be part of this CompilerPass internals tbh.
Steveb-p
approved these changes
Dec 17, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This is a part of bigger set of changes, to be merged together when ready
Related PRs:
Description:
This PR bumps Symfony to v6 with necessary codebase upgrades.
I've dropped
ezpublish.http_cache.purger,ezpublish.http_cache.purger, andezpublish.cache_clear.content.*service references usage as they no longer exist.ℹ️ Both REST integration tests and browser tests won't be green until the entire full-stack app is upgraded.
Key changes:
QA:
Sanities in the form of regression tests.
Documentation:
No documentation required.